Fix saving to an icloud folder. - #317
Open
tenderlove wants to merge 1 commit into
Open
Conversation
I had set an icloud folder is the default save location, but after a while the app stopped saving tracking files. I think there was a permissions error, but the error was swallowed. I'm not an iOS developer at all, so I don't know if this is the correct fix. This is what Claude told me: > When you first pick the folder in the document picker, iOS hands the > app a URL with a live access grant that stays valid for the rest of that > app run. So in that session — and until you fully quit the app — > saveToURL can write to the iCloud folder even without unlocking it. It > genuinely works. > After you force-quit and relaunch, that live grant is gone. Now the > only way back to the folder is the persisted bookmark > (Preferences.swift:343). Resolving the bookmark gives you the URL back, > but on iOS a resolved bookmark URL is locked until you call > startAccessingSecurityScopedResource(). And notice the getter doesn't > hold that open — it only unlocks briefly if the bookmark is stale > (:351-359), then immediately re-locks via defer. This might fix merlos#306, but I'm not sure how to test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had set an icloud folder is the default save location, but after a while the app stopped saving tracking files. I think there was a permissions error, but the error was swallowed.
I'm not an iOS developer at all, so I don't know if this is the correct fix. This is what Claude told me:
This might fix #306, but I'm not sure how to test.